Skip to content

Conversation

@csgillespie
Copy link
Member

oysteR 0.1.4 2025-10-08


General spring clean

@paul-botsco-2-0 paul-botsco-2-0 bot added the 😍 cla signed The CLA is signed label Oct 8, 2025
@csgillespie
Copy link
Member Author

@bhamail Hi Dan. Don't suppose we could merge this?

It fails the very stale CI, but that will take a while to fix. It fixes the R CMD checks on CRAN - which is the main one.

The security warnings are around an old requirements.txt that we don't use for installation - just parsing

@bhamail
Copy link
Contributor

bhamail commented Oct 23, 2025

@bhamail Hi Dan. Don't suppose we could merge this?

It fails the very stale CI, but that will take a while to fix. It fixes the R CMD checks on CRAN - which is the main one.

The security warnings are around an old requirements.txt that we don't use for installation - just parsing

@csgillespie Hi Colin! Yeah, that sound good to me. Happy to merge this puppy.

For kicks, I tried to get CI to run locally and ran into the error below:

====>> Build package
  #!/bin/bash -eo pipefail
R CMD build .
* checking for file ‘./DESCRIPTION’ ... OK
* preparing ‘oysteR’:
* checking DESCRIPTION meta-information ... OK
* installing the package to build vignettes
      -----------------------------------
ERROR: dependency ‘rjson’ is not available for package ‘oysteR’
* removing ‘/tmp/RtmpyP9wMn/Rinst3438e487ba/oysteR’
      -----------------------------------
ERROR: package installation failed
Error: 
Exited with code exit status 1

Any hints on how to resolve this? I'm happy to try and help fixing the CI issue after this PR is merged, but would appreciate your help hammering on it.

@bhamail
Copy link
Contributor

bhamail commented Oct 23, 2025

@collinpeters Oh, also looks like I will need to update changes from master into this branch. Duck and cover while I do that first.

@bhamail bhamail requested a review from a team as a code owner October 23, 2025 15:42
@bhamail
Copy link
Contributor

bhamail commented Oct 23, 2025

@collinpeters OK, I made some changes to hopefully get CI further along the path to happy. Will merge this puppy. Please take a look at main afterwards and see if we can get a happy build in circleci and/or githubActions.

@bhamail bhamail merged commit 7b29b3f into master Oct 23, 2025
1 of 6 checks passed
@bhamail bhamail deleted the air-formating branch October 23, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

😍 cla signed The CLA is signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants